Skip to content

small type stability fix #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025
Merged

small type stability fix #250

merged 3 commits into from
Jul 4, 2025

Conversation

Jutho
Copy link
Owner

@Jutho Jutho commented Jul 1, 2025

No description provided.

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.08%. Comparing base (9cc0573) to head (32abaf8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   83.08%   83.08%           
=======================================
  Files          44       44           
  Lines        5645     5647    +2     
=======================================
+ Hits         4690     4692    +2     
  Misses        955      955           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
Copy link
Collaborator

lkdvos commented Jul 2, 2025

I'd be okay with disabling the AD tests on nightly altogether to be honest, it's very often that this causes issues

@Jutho
Copy link
Owner Author

Jutho commented Jul 2, 2025

Do you know how to easily check whether the version it is running on is nightly or a stable version?

@lkdvos
Copy link
Collaborator

lkdvos commented Jul 3, 2025

I don't, and I'm not sure it's actually possible...

JuliaDiff/ChainRulesTestUtils.jl#294 should resolve the issue though.

As a side-note, I'm also not sure how valuable these nightly build tests are at all. I don't think we are really that strongly depending on any internals to expect breaking code, and we wouldn't catch performance changes anyways. I'm also okay with just disabling this altogether.

@Jutho
Copy link
Owner Author

Jutho commented Jul 3, 2025

Ok, new attempt, now disabling AD tests at nightly altogether. I am not ready to give up nightly tests alltogether.

@lkdvos
Copy link
Collaborator

lkdvos commented Jul 4, 2025

Looks like that worked 😉

@Jutho Jutho merged commit ffa6cf9 into master Jul 4, 2025
14 checks passed
@lkdvos lkdvos deleted the jh/smalltypestabilityfix branch July 4, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants